[NativeAOT-LLVM] Work around poor inlined memset
code quality in LLVM
#3183
+99
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See llvm/llvm-project#79692.
The diffs are a bit mixed, but still overall significantly positive. The regressions are due to the use of the "opaque"
add
pattern to form non-wrapping offset additions, something we can remove in favor of the newnusw
GEP feature once we update to the next EMSDK.Diffs (WasmDebugging):